Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adjustment documentation reference links #3122

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Add Adjustment documentation reference links #3122

merged 1 commit into from
Feb 28, 2019

Conversation

JuanCrg90
Copy link
Contributor

Description
This adds link references for some articles related to the adjustment documentation overview.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

jacobherrington
jacobherrington approved these changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs @JuanCrg90! 👍

kennyadsl
kennyadsl approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Left a comment, not blocking again 🙂

guides/source/developers/adjustments/overview.html.md
<!-- TODO:
Add link to taxation documentation to `is_included` item in the list.
-->
[value-added tax]: ../taxation/overview.html#sales-tax-and-value-added-tax
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this entity cited into Tax adjustments section as well (line 64). What about adding the link for that text as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Thank you 😄

@JuanCrg90
Add Adjustment documentation reference links
056d86b 
This adds link references for some articles related to the adjustment
documentation overview.
aitbw
aitbw approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @JuanCrg90 👏

@kennyadsl kennyadsl merged commit 713abf4 into solidusio:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@aitbw aitbw aitbw approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuanCrg90 @kennyadsl @aitbw @jacobherrington